Unified detail views, model

CHDataManagement/Views/Pages/LocalizedPageDetailView.swift

@@ -3,101 +3,41 @@ import SFSafeSymbols
 
 struct LocalizedPageDetailView: View {
 
+    let isExternalPage: Bool
+
     @ObservedObject
-    private var page: LocalizedPage
-
-    init(page: LocalizedPage, showImagePicker: Bool = false) {
-        self.page = page
-        self.showImagePicker = showImagePicker
-        self.newUrlString = page.urlString
-    }
-
-    @State
-    private var showImagePicker = false
-
-    @State
-    private var newUrlString: String
-
-    private let allowedCharactersInPostId = CharacterSet.alphanumerics.union(CharacterSet(charactersIn: "-")).inverted
-
-    private var idExists: Bool {
-        page.content.pages.contains {
-            $0.german.urlString == newUrlString
-            || $0.english.urlString == newUrlString
-        }
-    }
-
-    private var containsInvalidCharacters: Bool {
-        newUrlString.rangeOfCharacter(from: allowedCharactersInPostId) != nil
-    }
+    var page: LocalizedPage
 
     var body: some View {
         VStack(alignment: .leading) {
-            HStack {
-                Text("Page URL String")
-                    .font(.headline)
-                TextField("", text: $newUrlString)
-                    .textFieldStyle(.roundedBorder)
-                Button("Update", action: setNewId)
-                    .disabled(newUrlString.isEmpty || containsInvalidCharacters || idExists)
-            }
-            .padding(.bottom)
+            IdPropertyView(
+                id: $page.urlString,
+                title: "Page URL String",
+                footer: "The url component to use for the link to the page",
+                validation: page.isValid,
+                update: { page.urlString = $0 })
+            .disabled(isExternalPage)
 
-            Text("Link Preview Title")
-                .font(.headline)
-            OptionalTextField("", text: $page.linkPreviewTitle,
-                              prompt: page.title)
-                .textFieldStyle(.roundedBorder)
-            .padding(.bottom)
+            OptionalStringPropertyView(
+                title: "Preview Title",
+                text: $page.linkPreviewTitle,
+                prompt: page.title,
+                footer: "The title to use for the page when linking to it")
 
-            HStack {
-                Text("Link Preview Image")
-                    .font(.headline)
-                IconButton(symbol: .squareAndPencilCircleFill,
-                           size: 22,
-                           color: .blue) {
-                    showImagePicker = true
-                }
+            OptionalImagePropertyView(
+                title: "Preview Image",
+                selectedImage: $page.linkPreviewImage,
+                footer: "The image to show for previews of this page")
 
-                IconButton(symbol: .trashCircleFill,
-                           size: 22,
-                           color: .red) {
-                    page.linkPreviewImage = nil
-                }.disabled(page.linkPreviewImage == nil)
-                Spacer()
-            }
-
-            .buttonStyle(.plain)
-            if let image = page.linkPreviewImage {
-                image.imageToDisplay
-                    .resizable()
-                    .aspectRatio(contentMode: .fit)
-                    .frame(maxWidth: 400, maxHeight: 300)
-                    .cornerRadius(8)
-                Text(image.id)
-                    .font(.headline)
-            }
-
-            Text("Link Preview Description")
-                .font(.headline)
-                .padding(.top)
-            OptionalDescriptionField(text: $page.linkPreviewDescription)
-                .textFieldStyle(.roundedBorder)
-                .padding(.bottom)
+            OptionalTextFieldPropertyView(
+                title: "Preview Description",
+                text: $page.linkPreviewDescription,
+                footer: "The description to show in previews of the page")
         }
-        .sheet(isPresented: $showImagePicker) {
-            ImagePickerView(showImagePicker: $showImagePicker) { image in
-                page.linkPreviewImage = image
-            }
-        }
-    }
-
-    private func setNewId() {
-        page.urlString = newUrlString
     }
 }
 
 #Preview {
-    LocalizedPageDetailView(page: .english)
+    LocalizedPageDetailView(isExternalPage: false, page: .english)
         .environmentObject(Content.mock)
 }